Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastfilter dependency #4558

Closed
dankristensen opened this issue Oct 7, 2024 · 1 comment
Closed

fastfilter dependency #4558

dankristensen opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dankristensen
Copy link

I am using

  • OpenRewrite main branch

I am wondering why the module rewrite-java, has a dependency of
implementation("io.github.fastfilter:fastfilter:latest.release")

It is not used in this project, but instead used in rewrite-benchmarks

Is it some leftover that can be cleaned up?

@dankristensen dankristensen added the bug Something isn't working label Oct 7, 2024
@timtebeek
Copy link
Contributor

hi @dankristensen ! It appears like it might have accidentally been added to rewrite-java in d0a2487 ; I'd welcome a PR to remove it there if you're up for it. Either way thanks for pointing this out!

@timtebeek timtebeek added the good first issue Good for newcomers label Oct 8, 2024
@timtebeek timtebeek self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants