-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low level calls and geometry regeneration #560
Comments
May it would be good to have an option to disable automatic geometry regeneration. For example if you only update properties or similar elements that have no effect on the geometries. Or does BimServer already realize if a property does not affect geometries? Besides, does every single lowlevel call cause a new revision or can it be wrapped in a transaction? |
Those can (and have to) be wrapped in a transaction. I am refactoring them at the moment, but the plan is to have unit tests for all of them and better documentation as well, it's a feature that is almost never used, but I still think can have great potential. I don't particularly like the idea that the client-side developer becomes responsible for determining whether regenerating the geometry is necessary. For certain updates such as changing properties (within properysets) BIMserver should be able to quickly establish that no regeneration of geometry is necessary. |
Hmm, I agree, especially when you do multiple updates to different elements... Maybe it would help to have a list of elements/attributes that should not affect geometries. We don't require this functionallity, but propably soon will. |
Yeah that could be a quick fix for (probably) most situations |
In regards to issue #557 i've gone back to version 1.4.0 and there geometry regeneration is not breaking uppon new revision from lowlevelinterface. I would like to second @rubendel 's view on lowlevel call's potential. Am currently working on an application that focuses exclusively on updating propertyset properties. These do not require geometry regeneration at all. |
When the low level calls are used to create a new revision, all geometry is generated again, and stored again (linked to the new revision). Two possible improvements here are:
The text was updated successfully, but these errors were encountered: