When object has NSI entry, tag fix is displayed as brand fix

[danieldegroot2]

URL

No response

How to reproduce the issue?

When editing an object with an NSI entry, tag fix/upgrade/suggestion warnings are shown as non-standard brand warnings.
This happens even when the corresponding tags are already present and there are no other/new tags to change.
In the first case it could be useful to separate the outdated tag fix to avoid slightly confusing change to non-brand tag.
In the last case, it should be shown as i.e. 'outdated tags' as usual.

Steps to reproduce

1. Add new node
2. Add i.e. amenity=charging_station + name=EasyGo => 'non-standard brand`
3. Accept brand suggestion
4. Add survey_date=2023 => displays tag change as 'non-standard brand' change, while it is only `outdated tag' change.

Screenshot(s) or anything else?

https://www.openstreetmap.org/node/11001736756

Observed
With brand suggestion (when only amenity=charging_station + name=EasyGo is added)

With only the outdated tag suggestion remaining (when brand tags are already added)

Expected for last case (when brand tags are already added)

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app, RapiD version at mapwith.ai/rapid

What version numbers does this issue effect?

2.30.4, 2.31.0-dev, Rapid 2.5.0

Which browsers are you seeing this problem on?

Chrome

[tyrasd]

I can confirm this bug… There seems to be some unwanted interaction between the NSI matching and deprecated tag replacement validations. However I would not consider it as a critical bug, as the other warning is also not completely off (at least in English).

[Avan2021]

Since you confirmed this bug, can I work on this and if I make a pr, will it considered?

[tyrasd]

@Avan2021 As this bug is touching relatively complex parts of the code, I don't necessarily think it is a good first issue to tackle for a beginner like you. If you however find a proper solution it will of course be considered.