-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when calling zrok share reserved
without shareToken
#740
Comments
Nice find. It's a one-liner fix. Will include a fix in the next |
michaelquigley
added a commit
that referenced
this issue
Sep 17, 2024
michaelquigley
added a commit
that referenced
this issue
Sep 17, 2024
Fix Argument Handling in Reserved Sharing (#740)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Zrok docs mention just running
zrok share reserved
after creating a reserved instance.However, when I ran that I get the following:
Looking in the error message I went to the source file here
and realized it's expecting an argument. After the fact I saw that the help text usage implies the
<shareToken>
but a more helpful error message would be appreciated.Note - I tried cloning this and fixing myself but I dont think I understand enough about the project to get the error message showing correctly.
The text was updated successfully, but these errors were encountered: