Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go test ./... may break the current cluster set on kubeconfig #6801

Open
wpjunior opened this issue Aug 2, 2024 · 9 comments
Open

go test ./... may break the current cluster set on kubeconfig #6801

wpjunior opened this issue Aug 2, 2024 · 9 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@wpjunior
Copy link

wpjunior commented Aug 2, 2024

Bug Report

What did you do?

After the project bootstrap using operator-sdk, the directory test/e2e is created, if you run a go test ./... you may lose cert-manager and prometheus-operator on the current cluster set on kubeconfig.

What did you expect to see?

I think that is a accident, but we might prevent similar situations from happening to others. go test ./... should not trigger the e2e tests, we should use a environment variable to trigger e2e tests just on Makefile

@wpjunior wpjunior changed the title go test ./... may broke the current cluster set on kubeconfig go test ./... may break the current cluster set on kubeconfig Aug 5, 2024
@heinrichgrt
Copy link

The same happend to us today. We deleted cert-manager and prometheus on two clusters. This is really dangerous. It would be great, if you would set the k8s-context in the Makefile or in the test itself to something like operator-kind and not simply using users current k8s-context.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 10, 2025
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Feb 10, 2025
Copy link

openshift-ci bot commented Feb 10, 2025

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wpjunior
Copy link
Author

This issue is important to cluster safety

@wpjunior
Copy link
Author

/reopen

@openshift-ci openshift-ci bot reopened this Feb 10, 2025
Copy link

openshift-ci bot commented Feb 10, 2025

@wpjunior: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@heinrichgrt
Copy link

I do agree with @wpjunior this is a serious and very dangerous behaviour in the operator-sdk. I am a little bit annoyed that there is no response at all from the developer team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants