-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go test ./... may break the current cluster set on kubeconfig #6801
Comments
The same happend to us today. We deleted cert-manager and prometheus on two clusters. This is really dangerous. It would be great, if you would set the k8s-context in the Makefile or in the test itself to something like operator-kind and not simply using users current k8s-context. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This issue is important to cluster safety |
/reopen |
@wpjunior: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I do agree with @wpjunior this is a serious and very dangerous behaviour in the operator-sdk. I am a little bit annoyed that there is no response at all from the developer team. |
Bug Report
What did you do?
After the project bootstrap using operator-sdk, the directory test/e2e is created, if you run a go test ./... you may lose cert-manager and prometheus-operator on the current cluster set on kubeconfig.
What did you expect to see?
I think that is a accident, but we might prevent similar situations from happening to others. go test ./... should not trigger the e2e tests, we should use a environment variable to trigger e2e tests just on Makefile
The text was updated successfully, but these errors were encountered: