forked from presidentbeef/brakeman
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathbrakeman.rb
541 lines (452 loc) · 15.9 KB
/
brakeman.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
require 'set'
module Brakeman
#This exit code is used when warnings are found and the --exit-on-warn
#option is set
Warnings_Found_Exit_Code = 3
#Exit code returned when no Rails application is detected
No_App_Found_Exit_Code = 4
#Exit code returned when brakeman was outdated
Not_Latest_Version_Exit_Code = 5
#Exit code returned when user requests non-existent checks
Missing_Checks_Exit_Code = 6
#Exit code returned when errors were found and the --exit-on-error
#option is set
Errors_Found_Exit_Code = 7
@debug = false
@quiet = false
@loaded_dependencies = []
@vendored_paths = false
#Run Brakeman scan. Returns Tracker object.
#
#Options:
#
# * :app_path - path to root of Rails app (required)
# * :additional_checks_path - array of additional directories containing additional out-of-tree checks to run
# * :additional_libs_path - array of additional application relative lib directories (ex. app/mailers) to process
# * :assume_all_routes - assume all methods are routes (default: true)
# * :check_arguments - check arguments of methods (default: true)
# * :collapse_mass_assignment - report unprotected models in single warning (default: false)
# * :combine_locations - combine warning locations (default: true)
# * :config_file - configuration file
# * :escape_html - escape HTML by default (automatic)
# * :exit_on_warn - return false if warnings found, true otherwise. Not recommended for library use (default: false)
# * :github_repo - github repo to use for file links (user/repo[/path][@ref])
# * :highlight_user_input - highlight user input in reported warnings (default: true)
# * :html_style - path to CSS file
# * :ignore_model_output - consider models safe (default: false)
# * :index_libs - add libraries to call index (default: true)
# * :interprocedural - limited interprocedural processing of method calls (default: false)
# * :message_limit - limit length of messages
# * :min_confidence - minimum confidence (0-2, 0 is highest)
# * :output_files - files for output
# * :output_formats - formats for output (:to_s, :to_tabs, :to_csv, :to_html)
# * :parallel_checks - run checks in parallel (default: true)
# * :print_report - if no output file specified, print to stdout (default: false)
# * :quiet - suppress most messages (default: true)
# * :rails3 - force Rails 3 mode (automatic)
# * :report_routes - show found routes on controllers (default: false)
# * :run_checks - array of checks to run (run all if not specified)
# * :safe_methods - array of methods to consider safe
# * :skip_libs - do not process lib/ directory (default: false)
# * :skip_checks - checks not to run (run all if not specified)
# * :absolute_paths - show absolute path of each file (default: false)
# * :summary_only - only output summary section of report for plain/table (:summary_only, :no_summary, true)
#
#Alternatively, just supply a path as a string.
def self.run options
options = set_options options
@quiet = !!options[:quiet]
@debug = !!options[:debug]
if @quiet
options[:report_progress] = false
end
scan options
end
#Sets up options for run, checks given application path
def self.set_options options
if options.is_a? String
options = { :app_path => options }
end
if options[:quiet] == :command_line
command_line = true
options.delete :quiet
end
options = default_options.merge(load_options(options)).merge(options)
if options[:quiet].nil? and not command_line
options[:quiet] = true
end
options[:output_formats] = get_output_formats options
options[:github_url] = get_github_url options
options
end
#Load options from YAML file
def self.load_options line_options
custom_location = line_options[:config_file]
quiet = line_options[:quiet]
app_path = line_options[:app_path]
#Load configuration file
if config = config_file(custom_location, app_path)
require 'date' # https://github.com/dtao/safe_yaml/issues/80
self.load_brakeman_dependency 'safe_yaml/load'
options = SafeYAML.load_file config, :deserialize_symbols => true
if options
options.each { |k, v| options[k] = Set.new v if v.is_a? Array }
# After parsing the yaml config file for options, convert any string keys into symbols.
options.keys.select {|k| k.is_a? String}.map {|k| k.to_sym }.each {|k| options[k] = options[k.to_s]; options.delete(k.to_s) }
# notify if options[:quiet] and quiet is nil||false
notify "[Notice] Using configuration in #{config}" unless (options[:quiet] || quiet)
options
else
notify "[Notice] Empty configuration file: #{config}" unless quiet
{}
end
else
{}
end
end
CONFIG_FILES = [
File.expand_path("~/.brakeman/config.yml"),
File.expand_path("/etc/brakeman/config.yml")
]
def self.config_file custom_location, app_path
app_config = File.expand_path(File.join(app_path, "config", "brakeman.yml"))
supported_locations = [File.expand_path(custom_location || ""), app_config] + CONFIG_FILES
supported_locations.detect {|f| File.file?(f) }
end
#Default set of options
def self.default_options
{ :assume_all_routes => true,
:skip_checks => Set.new,
:check_arguments => true,
:safe_methods => Set.new,
:min_confidence => 2,
:combine_locations => true,
:collapse_mass_assignment => false,
:highlight_user_input => true,
:ignore_redirect_to_model => true,
:ignore_model_output => false,
:index_libs => true,
:message_limit => 100,
:parallel_checks => true,
:relative_path => false,
:report_progress => true,
:html_style => "#{File.expand_path(File.dirname(__FILE__))}/brakeman/format/style.css",
:output_color => true,
:engine_paths => ["engines/*"]
}
end
#Determine output formats based on options[:output_formats]
#or options[:output_files]
def self.get_output_formats options
#Set output format
if options[:output_format] && options[:output_files] && options[:output_files].size > 1
raise ArgumentError, "Cannot specify output format if multiple output files specified"
end
if options[:output_format]
get_formats_from_output_format options[:output_format]
elsif options[:output_files]
get_formats_from_output_files options[:output_files]
else
begin
self.load_brakeman_dependency 'terminal-table', :allow_fail
return [:to_s]
rescue LoadError
return [:to_json]
end
end
end
def self.get_formats_from_output_format output_format
case output_format
when :html, :to_html
[:to_html]
when :csv, :to_csv
[:to_csv]
when :pdf, :to_pdf
[:to_pdf]
when :tabs, :to_tabs
[:to_tabs]
when :json, :to_json
[:to_json]
when :markdown, :to_markdown
[:to_markdown]
when :cc, :to_cc, :codeclimate, :to_codeclimate
[:to_codeclimate]
when :plain ,:to_plain
[:to_plain]
else
[:to_s]
end
end
private_class_method :get_formats_from_output_format
def self.get_formats_from_output_files output_files
output_files.map do |output_file|
case output_file
when /\.html$/i
:to_html
when /\.csv$/i
:to_csv
when /\.pdf$/i
:to_pdf
when /\.tabs$/i
:to_tabs
when /\.json$/i
:to_json
when /\.md$/i
:to_markdown
when /(\.cc|\.codeclimate)$/i
:to_codeclimate
when /\.plain$/i
:to_plain
else
:to_s
end
end
end
private_class_method :get_formats_from_output_files
def self.get_github_url options
if github_repo = options[:github_repo]
full_repo, ref = github_repo.split '@', 2
name, repo, path = full_repo.split '/', 3
unless name && repo && !(name.empty? || repo.empty?)
raise ArgumentError, "Invalid GitHub repository format"
end
path.chomp '/' if path
ref ||= 'master'
['https://github.com', name, repo, 'blob', ref, path].compact.join '/'
else
nil
end
end
private_class_method :get_github_url
#Output list of checks (for `-k` option)
def self.list_checks options
require 'brakeman/scanner'
add_external_checks options
if options[:list_optional_checks]
$stderr.puts "Optional Checks:"
checks = Checks.optional_checks
else
$stderr.puts "Available Checks:"
checks = Checks.checks
end
format_length = 30
$stderr.puts "-" * format_length
checks.each do |check|
$stderr.printf("%-#{format_length}s%s\n", check.name, check.description)
end
end
#Installs Rake task for running Brakeman,
#which basically means copying `lib/brakeman/brakeman.rake` to
#`lib/tasks/brakeman.rake` in the current Rails application.
def self.install_rake_task install_path = nil
if install_path
rake_path = File.join(install_path, "Rakefile")
task_path = File.join(install_path, "lib", "tasks", "brakeman.rake")
else
rake_path = "Rakefile"
task_path = File.join("lib", "tasks", "brakeman.rake")
end
if not File.exist? rake_path
raise RakeInstallError, "No Rakefile detected"
elsif File.exist? task_path
raise RakeInstallError, "Task already exists"
end
require 'fileutils'
if not File.exist? "lib/tasks"
notify "Creating lib/tasks"
FileUtils.mkdir_p "lib/tasks"
end
path = File.expand_path(File.dirname(__FILE__))
FileUtils.cp "#{path}/brakeman/brakeman.rake", task_path
if File.exist? task_path
notify "Task created in #{task_path}"
notify "Usage: rake brakeman:run[output_file]"
else
raise RakeInstallError, "Could not create task"
end
end
#Output configuration to YAML
def self.dump_config options
require 'yaml'
if options[:create_config].is_a? String
file = options[:create_config]
else
file = nil
end
options.delete :create_config
options.each do |k,v|
if v.is_a? Set
options[k] = v.to_a
end
end
if file
File.open file, "w" do |f|
YAML.dump options, f
end
notify "Output configuration to #{file}"
else
notify YAML.dump(options)
end
end
def self.ensure_latest
current = Brakeman::Version
latest = Gem.latest_version_for('brakeman').to_s
if current != latest
"Brakeman #{current} is not the latest version #{latest}"
end
end
#Run a scan. Generally called from Brakeman.run instead of directly.
def self.scan options
#Load scanner
notify "Loading scanner..."
begin
require 'brakeman/scanner'
rescue LoadError
raise NoBrakemanError, "Cannot find lib/ directory."
end
add_external_checks options
#Start scanning
scanner = Scanner.new options
tracker = scanner.tracker
check_for_missing_checks options[:run_checks], options[:skip_checks]
notify "Processing application in #{tracker.app_path}"
scanner.process
if options[:parallel_checks]
notify "Running checks in parallel..."
else
notify "Runnning checks..."
end
tracker.run_checks
self.filter_warnings tracker, options
if options[:output_files]
notify "Generating report..."
write_report_to_files tracker, options[:output_files]
elsif options[:print_report]
notify "Generating report..."
write_report_to_formats tracker, options[:output_formats]
end
tracker
end
def self.write_report_to_files tracker, output_files
require 'fileutils'
tracker.options[:output_color] = false
output_files.each_with_index do |output_file, idx|
dir = File.dirname(output_file)
unless Dir.exist? dir
FileUtils.mkdir_p(dir)
end
File.open output_file, "w" do |f|
f.write tracker.report.format(tracker.options[:output_formats][idx])
end
notify "Report saved in '#{output_file}'"
end
end
private_class_method :write_report_to_files
def self.write_report_to_formats tracker, output_formats
unless $stdout.tty?
tracker.options[:output_color] = false
end
output_formats.each do |output_format|
puts tracker.report.format(output_format)
end
end
private_class_method :write_report_to_formats
#Rescan a subset of files in a Rails application.
#
#A full scan must have been run already to use this method.
#The returned Tracker object from Brakeman.run is used as a starting point
#for the rescan.
#
#Options may be given as a hash with the same values as Brakeman.run.
#Note that these options will be merged into the Tracker.
#
#This method returns a RescanReport object with information about the scan.
#However, the Tracker object will also be modified as the scan is run.
def self.rescan tracker, files, options = {}
require 'brakeman/rescanner'
tracker.options.merge! options
@quiet = !!tracker.options[:quiet]
@debug = !!tracker.options[:debug]
Rescanner.new(tracker.options, tracker.processor, files).recheck
end
def self.notify message
$stderr.puts message unless @quiet
end
def self.debug message
$stderr.puts message if @debug
end
# Compare JSON ouptut from a previous scan and return the diff of the two scans
def self.compare options
require 'json'
require 'brakeman/differ'
raise ArgumentError.new("Comparison file doesn't exist") unless File.exist? options[:previous_results_json]
begin
previous_results = JSON.parse(File.read(options[:previous_results_json]), :symbolize_names => true)[:warnings]
rescue JSON::ParserError
self.notify "Error parsing comparison file: #{options[:previous_results_json]}"
exit!
end
tracker = run(options)
new_results = JSON.parse(tracker.report.to_json, :symbolize_names => true)[:warnings]
Brakeman::Differ.new(new_results, previous_results).diff
end
def self.load_brakeman_dependency name, allow_fail = false
return if @loaded_dependencies.include? name
unless @vendored_paths
path_load = "#{File.expand_path(File.dirname(__FILE__))}/../bundle/load.rb"
if File.exist? path_load
require path_load
end
@vendored_paths = true
end
begin
require name
rescue LoadError => e
if allow_fail
raise e
else
$stderr.puts e.message
$stderr.puts "Please install the appropriate dependency: #{name}."
exit!(-1)
end
end
end
def self.filter_warnings tracker, options
require 'brakeman/report/ignore/config'
app_tree = Brakeman::AppTree.from_options(options)
if options[:ignore_file]
file = options[:ignore_file]
elsif app_tree.exists? "config/brakeman.ignore"
file = app_tree.expand_path("config/brakeman.ignore")
elsif not options[:interactive_ignore]
return
end
notify "Filtering warnings..."
if options[:interactive_ignore]
require 'brakeman/report/ignore/interactive'
config = InteractiveIgnorer.new(file, tracker.warnings).start
else
notify "[Notice] Using '#{file}' to filter warnings"
config = IgnoreConfig.new(file, tracker.warnings)
config.read_from_file
config.filter_ignored
end
tracker.ignored_filter = config
end
def self.add_external_checks options
options[:additional_checks_path].each do |path|
Brakeman::Checks.initialize_checks path
end if options[:additional_checks_path]
end
def self.check_for_missing_checks included_checks, excluded_checks
missing = Brakeman::Checks.missing_checks(included_checks || Set.new, excluded_checks || Set.new)
unless missing.empty?
raise MissingChecksError, "Could not find specified check#{missing.length > 1 ? 's' : ''}: #{missing.to_a.join(', ')}"
end
end
class DependencyError < RuntimeError; end
class RakeInstallError < RuntimeError; end
class NoBrakemanError < RuntimeError; end
class NoApplication < RuntimeError; end
class MissingChecksError < RuntimeError; end
end