Skip to content

Session logMessage is printing to stdout, even though COHERENCE_SESSION_DEBUG is set to false #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdelapenya opened this issue May 7, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@mdelapenya
Copy link

mdelapenya commented May 7, 2025

Describe the bug
I noticed that the client is printing session info even though the env var for disabling it is set:

This is the output of a benchmark test in the gofiber/storage repository, which uses this client. See gofiber/storage#1724 and the failure when processing the benchmarks files here.

2025/05/07 06:28:05 INFO: Session [a0d32c93-2a5b-46a4-b01b-d5b9c7686cf0] connected to [localhost:32943] Coherence version: 25.03.1, serverProtocolVersion: 1, proxyMemberId: 1
2025/05/07 06:30:34 INFO: Session [a0d32c93-2a5b-46a4-b01b-d5b9c7686cf0] closed
goos: darwin
goarch: arm64
pkg: github.com/gofiber/storage/coherence
cpu: Apple M1 Pro
Benchmark_Coherence_SetAndDelete-8   	
2025/05/07 06:37:41 INFO: Session [ca7ebf8a-8b31-4a3e-a9cd-562e38b49325] connected to [localhost:32946] Coherence version: 25.03.1, serverProtocolVersion: 1, proxyMemberId: 1
2025/05/07 06:41:16 INFO: Session [ca7ebf8a-8b31-4a3e-a9cd-562e38b49325] closed
      14	15348325926 ns/op	   10403 B/op	     226 allocs/op
PASS

Benchmarks processing failure:

Error: No benchmark result was found in /home/runner/work/storage/storage/coherence/output.txt. Benchmark output was '2025/05/07 04:24:55 INFO: Session [0797f0d6-d581-4478-babc-0b3ce21d62ce] connected to [localhost:32769] Coherence version: 25.03.1, serverProtocolVersion: 1, proxyMemberId: 1

To Reproduce
Steps to reproduce the behaviour:

  • clone https://github.com/gofiber/storage
  • set COHERENCE_SESSION_DEBUG=false in the current terminal
  • run a benchmark in the coherence module
  • session logs are printed out to stdout

Expected behaviour
session logs are not printed out to stdout

Screenshots
If applicable, add screenshots to help explain your problem

Image

Environment (please complete the following information):

  • Coherence Go Client Version: github.com/oracle/coherence-go-client/v2 v2.1.0
  • Go Version - output of go version: Go 1.23 and 1.24
  • Coherence cluster version you are connecting to: Docker, ghcr.io/oracle/coherence-ce:25.03.1-graal
  • Coherence cluster edition: Community Edition/Enterprise Edition or Grid Edition: Community
  • Java version and Java vendor used for Coherence: the one in the Docker image
  • OS Coherence cluster is running on: [e.g. Linux]: the one in the Docker image
  • OS Version Coherence cluster is running onL [e.g. OEL7]: the one in the Docker image
  • Is this a container/cloud environment, e.g. Docker, CRI-O, Kubernetes, if so include additional information about the container environment, versions etc. Yes, Docker

Additional context
Add any other context about the problem here.

I'm open to work on this

@mdelapenya
Copy link
Author

I'm about to send a PR from https://github.com/oracle/coherence-go-client/compare/main...mdelapenya:coherence-go-client:123-fix-session-debug-logs?expand=1, waiting for company thoughts on the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant