Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weblogic Maven Plugin version references in pom.xml is not updated on running weblogic openrewrite #14

Open
gnsuryan opened this issue Dec 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@gnsuryan
Copy link
Member

gnsuryan commented Dec 4, 2024

Weblogic Maven Plugin version references in pom.xml is not updated on running weblogic openrewrite

During migration of WebLogic maven plugin based applications from old versions of WebLogic (122140, 141100) to 141200 using
WebLogic openrewrite, the WebLogic maven plugin versions are not updated. They remain the same as it was earlier.

To reproduce the issue, follow the below steps:

Pre-requisites:

JDK17/21
Maven 3.9.8 or above

git clone https://github.com/dveselka/WebLogic.git to a directory, say /scratch/$USER/openrewrite-testing/

cd /scratch/$USER/openrewrite-testing/WebLogic/dave-basic-project/dave-basic-webapp-project/

Open pom.xml and verify the WebLogic maven Plugin version. It should be 14.1.1.0.0

Now run open-rewrite command to migrate to 141200 JDK17/21 using below commands:

For JDK17
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run
-Drewrite.recipeArtifactCoordinates=com.oracle.WebLogic.rewrite:rewrite-WebLogic:0.3.0
-Drewrite.activeRecipes=com.oracle.WebLogic.rewrite.UpgradeTo1412,org.openrewrite.java.migrate.UpgradeToJava17

For JDK21
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run
-Drewrite.recipeArtifactCoordinates=com.oracle.WebLogic.rewrite:rewrite-WebLogic:0.3.0
-Drewrite.activeRecipes=com.oracle.WebLogic.rewrite.UpgradeTo1412,org.openrewrite.java.migrate.UpgradeToJava21

Verify the changes in pom.xml. You can notice that pom.xml has got modified with changes in
JDK version, maven war plugin version etc. But the WebLogic Maven Plugin version remains the same

The expectation is that after migration, the WebLogic Maven Plugin version has to be modified accordingly.
In this case, the WebLogic Maven Plugin has to be updated to 14.1.2.0.0 from 14.1.1.0.0

@david-cabelus-oracle
Copy link
Member

@junior - any updates on this issue?

@junior junior added bug Something isn't working good first issue Good for newcomers labels Jan 21, 2025
@junior
Copy link
Member

junior commented Jan 21, 2025

Issue have been resolved on the version 0.4.0.

0.5.0 (That will also include the LATEST notation), will have all the unit tests and will be the officially version that fix all the version updates in all hierarchy of the pom.xml and griddle build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants