Patch extract check based on presence of {{unarchive_dir}}/{{patchid}}/README.txt doesn't work for combo patches

[ThiloSolbrig]

Unarchive module for extracting patches uses creates: attribute to check if patches have to be extracted or not. This is based on the existence of the file unarchive_dir/patchid/README.txt. In Oracle's combo patches, though, there's no such file under patchid directory, just a README.html. Hence combo patches will always be extracted, regardless of they already were before.
To make it working a bit more generic, it should be safe to omit the file check and just check for existence of unarchive_dir/patchid directory, which always exists in combos, one-offs, RUs etc.

[ThiloSolbrig]

Would be fixed by #483

[Rendanic]

Hi Thilo,
there is an attribute (creates) in oracle_sw_patches where a filename inside the archive could be defined when the default is not working.

I added the current default in ansible-oracle 4.x to make the configuration of oracle_sw_patcheseasier, due to the fact that most patches have the same structure.

Example:

oracle_sw_patches:
  - filename: p27468969_122010_Linux-x86-64.zip
    patchid: 27468969
    version: 12.2.0.1
    patchversion: 12.2.0.1.180417
    description: GI-RU-April-2018
    creates: 27468969/27674384/README.txt

If that is not working we have a bug in the code.
I'll check if I could add a testcase to molecule, so a different creates is working like expected.

If I didn't miss something, the change is not needed, because it could be configured with the existing code without reducing the check to 1 parent directory.

Regards
Thorsten

[ThiloSolbrig]

Hi Thorsten,
Yes, you're basically right. The issue with combo patches could easily be worked around by setting the creates: attribute. Thanks for pointing this out. Anyway, removing the README.txt file from the check and only check for the presence of the extract directory would introduce a better default, imho. So, well, it's not really a bug and thus not really to be fixed. I'd leave it up to you to merge or reject.
Best regards,
Thilo.