Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check whether download/data is complete #14

Closed
osm-ToniE opened this issue Apr 20, 2018 · 0 comments
Closed

check whether download/data is complete #14

osm-ToniE opened this issue Apr 20, 2018 · 0 comments
Assignees
@osm-ToniE
Labels
enhancement New feature or request

Comments

@osm-ToniE
Copy link
Owner

Some donwloads via Overpass-API query do not include all data that is references in the relations.
I.e. there are some routes with way members, but details for the ways (tags and node-IDs) are not in the downloaded data. This may also the case for member nodes.
The code depends on completeness of data and does not check like if ( $WAYS($way_id)->{'first_node'} )

Before analyzing route relations, check for completeness of data.
If not complete, issue an error in the analysis file (for this route) and on STDERR specifying the Relation-ID.
Furthermore skip check which depend in completeness of data.
@osm-ToniE osm-ToniE added the enhancement New feature or request label Apr 20, 2018
@osm-ToniE osm-ToniE self-assigned this Apr 20, 2018
osm-ToniE added a commit that referenced this issue Apr 20, 2018
@osm-ToniE
fix issue #14
3794af1 
Some donwloads via Overpass-API query do not include all data that is references in the relations.
I.e. there are some routes with way members, but details for the ways (tags and node-IDs) are not in the downloaded data. This may also the case for member nodes.
The code depends on completeness of data and does not check like if ( $WAYS($way_id)->{'first_node'} )

Before analyzing route relations, check for completeness of data.
If not complete, issue an error in the analysis file (for this route) and on STDERR specifying the Relation-ID.
Furthermore skip check which depend in completeness of data.
osm-ToniE added a commit that referenced this issue Apr 21, 2018
@osm-ToniE
fix root cause of issue #14
0955afe 
input data was not complte due to a malformed overpass-api query.
At least for DE-HB-VBN, the rule

rel(br);

selected a relation with type=network (name ~ Westfalentarif) which itself includes type=route relations.

rel[type~'route'];

selected a route_taster relation (of bus 353) in the enxt step. Finally

rel(r.routes);

retrieved the two route relations of bus 323.
No further downlaod of relation, way and node members of these two relations was done.

Solution:

replace

rel[type~'route'];

by

rel[type='route'];

so that only route relations are selected, whose relation, way and node members are finally downloaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osm-ToniE osm-ToniE

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osm-ToniE