This repository has been archived by the owner on Jun 12, 2019. It is now read-only.
feat: domain trade and webhosting product #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesnault
suggested changes
Jan 8, 2017
| common.Check(err) | ||
| } | ||
| item, err := client.OrderAddCartServiceOption(domain, types.OrderCartServiceOptionDomainPost{ | ||
| Duration: "P1Y", |
There was a problem hiding this comment.
why not arg with default value ? or a comment
| } | ||
| } | ||
| if serviceOptionChoosed == nil { | ||
| err = fmt.Errorf("Cannot find service options of type trade for domain %s", domain) |
There was a problem hiding this comment.
common.Exit("Cannot find service options of type trade for domain %s", domain)
| domain := args[0] | ||
|
|
||
| if withOwner == "" { | ||
| err := fmt.Errorf("Missing withOwner option") |
There was a problem hiding this comment.
common.Exit("Missing withOwner option") or common.WrongUsage by adding new arg for err description.
| // OrderAddProductWebHosting post a new webHosting product in your cart | ||
| func (c *Client) OrderAddProductWebHosting(cartID string, orderCartWebHostingPost types.OrderCartWebHostingPost) (*types.OrderCartItem, error) { | ||
| if cartID == "" { | ||
| return nil, errors.New("Error 404: \"Invalid Cart ID\"") |
There was a problem hiding this comment.
why 404 and not just Cart ID cannot be null ?
yesnault
approved these changes
Jan 9, 2017
feat: add push webhosting product into a cart wording: add uppercase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add push webhosting product into a cart
feat: add trade cli