Skip to content

REF: use common utilities when implementing EA._get_common_dtype #43454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mzeitlin11 opened this issue Sep 7, 2021 · 3 comments
Closed

REF: use common utilities when implementing EA._get_common_dtype #43454

mzeitlin11 opened this issue Sep 7, 2021 · 3 comments
Labels
Closing Candidate May be closeable, needs more eyeballs Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code

Comments

@mzeitlin11
Copy link
Member

From #43409, #43409 (comment).

Look to use is_*_dtype instead of isinstance when implementing _get_common_dtype for EA's.
@mzeitlin11 mzeitlin11 added Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code labels Sep 7, 2021
@jbrockmendel
Copy link
Member

jbrockmendel commented Sep 8, 2021 •
edited
Loading

is_*_dtype in general is very slow

@jreback
Copy link
Contributor

jreback commented Sep 9, 2021

i think we should fix that (eg there was a fast path pr from joris or tom) i think at some point

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label Jan 24, 2023
@mroeschke
Copy link
Member

I think we've settle on kind and isinstance checks as the common pattern now so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closing Candidate May be closeable, needs more eyeballs Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jreback @jbrockmendel @mroeschke @mzeitlin11