Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QT from 5.12.4 to 5.13.0 compilation fails #24

Closed
substring opened this issue Jul 2, 2019 · 6 comments · Fixed by #25
Closed

QT from 5.12.4 to 5.13.0 compilation fails #24

substring opened this issue Jul 2, 2019 · 6 comments · Fixed by #25

Comments

@substring
Copy link
Contributor

Hi,

This version of QT produces many errors error: ‘QString::null’ is deprecated: use QString()
@substring
Copy link
Contributor Author

later complains with error: ‘const QBrush& QPalette::background() const’ is deprecated: Use QPalette::window()

@panzi
Copy link
Owner

panzi commented Jul 2, 2019

Thank you for the report.
I'm, as always, on an outdated Linux distribution. If you can fix those errors and send a pull request that would be awesome! :D

@substring
Copy link
Contributor Author

Sure I can as soon as I'm done testing it. Then you'd need to test it on an older version of QT, but looks like it's no problem for you 😄

Thank you for the quick feedback 😉

substring added a commit to substring/test that referenced this issue Jul 2, 2019
@substring
qjoypad: patch it, see panzi/qjoypad#24
2a3a3b9
@substring substring mentioned this issue Jul 2, 2019
Merged
@panzi panzi closed this as completed in #25 Jul 6, 2019
@panzi
Copy link
Owner

panzi commented Jul 6, 2019

Works with Qt 5.11.3
Thank you! :D

@substring
Copy link
Contributor Author

Nice, you're welcome 😃
Could you consider releasing 4.3.1 ?

@panzi
Copy link
Owner

panzi commented Jul 10, 2019

done https://github.com/panzi/qjoypad/releases/tag/v4.3.1 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compilation with QT 5.13 substring/qjoypad
2 participants
@panzi @substring