Revert "Enfore optional parameters in callable types"

This reverts commit 0910d70.

Author: ondrejmirtes

src/Type/CallableType.php

@@ -146,12 +146,7 @@ public function describe(VerbosityLevel $level): string
 			fn (): string => sprintf(
 				'callable(%s): %s',
 				implode(', ', array_map(
-					static fn (ParameterReflection $param): string => sprintf(
-						'%s%s%s',
-						$param->isVariadic() ? '...' : '',
-						$param->getType()->describe($level),
-						$param->isOptional() && !$param->isVariadic() ? '=' : '',
-					),
+					static fn (ParameterReflection $param): string => sprintf('%s%s', $param->isVariadic() ? '...' : '', $param->getType()->describe($level)),
 					$this->getParameters(),
 				)),
 				$this->returnType->describe($level),

src/Type/CallableTypeHelper.php

@@ -29,11 +29,6 @@ public static function isParametersAcceptorSuperTypeOf(
 
 			$ourParameter = $ourParameters[$i];
 			$ourParameterType = $ourParameter->getType();
-
-			if ($ourParameter->isOptional() && !$theirParameter->isOptional()) {
-				return TrinaryLogic::createNo();
-			}
-
 			if ($treatMixedAsAny) {
 				$isSuperType = $theirParameter->getType()->accepts($ourParameterType, true);
 			} else {

src/Type/ClosureType.php

@@ -150,15 +150,7 @@ public function describe(VerbosityLevel $level): string
 			static fn (): string => 'Closure',
 			fn (): string => sprintf(
 				'Closure(%s): %s',
-				implode(', ', array_map(
-					static fn (ParameterReflection $param): string => sprintf(
-						'%s%s%s',
-						$param->isVariadic() ? '...' : '',
-						$param->getType()->describe($level),
-						$param->isOptional() && !$param->isVariadic() ? '=' : '',
-					),
-					$this->parameters,
-				)),
+				implode(', ', array_map(static fn (ParameterReflection $parameter): string => sprintf('%s%s', $parameter->isVariadic() ? '...' : '', $parameter->getType()->describe($level)), $this->parameters)),
 				$this->returnType->describe($level),
 			),
 		);

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

@@ -763,9 +763,9 @@ public function testDiscussion7124(): void
 
 		$errors = $this->runAnalyse(__DIR__ . '/data/discussion-7124.php');
 		$this->assertCount(4, $errors);
-		$this->assertSame('Parameter #2 $callback of function Discussion7124\filter expects callable(bool, int=): bool, Closure(int, bool): bool given.', $errors[0]->getMessage());
+		$this->assertSame('Parameter #2 $callback of function Discussion7124\filter expects callable(bool, int): bool, Closure(int, bool): bool given.', $errors[0]->getMessage());
 		$this->assertSame(38, $errors[0]->getLine());
-		$this->assertSame('Parameter #2 $callback of function Discussion7124\filter expects callable(bool, int=): bool, Closure(int): bool given.', $errors[1]->getMessage());
+		$this->assertSame('Parameter #2 $callback of function Discussion7124\filter expects callable(bool, int): bool, Closure(int): bool given.', $errors[1]->getMessage());
 		$this->assertSame(45, $errors[1]->getLine());
 		$this->assertSame('Parameter #2 $callback of function Discussion7124\filter expects callable(int): bool, Closure(bool): bool given.', $errors[2]->getMessage());
 		$this->assertSame(52, $errors[2]->getLine());
@@ -841,14 +841,6 @@ public function testBug7351(): void
 		$this->assertNoErrors($errors);
 	}
 
-	public function testBug7320(): void
-	{
-		$errors = $this->runAnalyse(__DIR__ . '/data/bug-7320.php');
-		$this->assertCount(1, $errors);
-		$this->assertSame('Parameter #1 $c of function Bug7320\foo expects callable(int=): void, Closure(int): void given.', $errors[0]->getMessage());
-		$this->assertSame(13, $errors[0]->getLine());
-	}
-
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]