Use __eq__ methods inequality too.

Author: cthulahoops

vm/src/obj/objobject.rs

@@ -1,3 +1,4 @@
+use super::super::objbool;
 use super::super::pyobject::{
     AttributeProtocol, IdProtocol, PyContext, PyFuncArgs, PyObject, PyObjectKind, PyObjectRef,
     PyResult, TypeProtocol,
@@ -38,6 +39,16 @@ fn object_eq(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
     Ok(vm.ctx.new_bool(zelf.is(other)))
 }
 
+fn object_ne(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
+    arg_check!(
+        vm,
+        args,
+        required = [(zelf, Some(vm.ctx.object())), (other, None)]
+    );
+    let eq = vm.call_method(zelf.clone(), "__eq__", vec![other.clone()])?;
+    objbool::not(vm, &eq)
+}
+
 fn object_str(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
     arg_check!(vm, args, required = [(obj, Some(vm.ctx.object()))]);
     let type_name = objtype::get_type_name(&obj.typ());
@@ -49,6 +60,7 @@ pub fn init(context: &PyContext) {
     let ref object = context.object;
     object.set_attr("__new__", context.new_rustfunc(new_instance));
     object.set_attr("__eq__", context.new_rustfunc(object_eq));
+    object.set_attr("__ne__", context.new_rustfunc(object_ne));
     object.set_attr("__dict__", context.new_member_descriptor(object_dict));
     object.set_attr("__str__", context.new_rustfunc(object_str));
 }

vm/src/objbool.rs

@@ -45,14 +45,23 @@ fn bool_eq(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
         required = [(zelf, Some(vm.ctx.bool_type())), (other, None)]
     );
 
-    let result = if objtype::isinstance(zelf.clone(), vm.ctx.bool_type()) {
+    let result = if objtype::isinstance(other.clone(), vm.ctx.bool_type()) {
         get_value(zelf) == get_value(other)
     } else {
         false
     };
     Ok(vm.ctx.new_bool(result))
 }
 
+pub fn not(vm: &mut VirtualMachine, obj: &PyObjectRef) -> PyResult {
+    if objtype::isinstance(obj.clone(), vm.ctx.bool_type()) {
+        let value = get_value(obj);
+        Ok(vm.ctx.new_bool(!value))
+    } else {
+        Err(vm.new_type_error(format!("Can only invert a bool, on {:?}", obj)))
+    }
+}
+
 // Retrieve inner int value:
 pub fn get_value(obj: &PyObjectRef) -> bool {
     if let PyObjectKind::Boolean { value } = &obj.borrow().kind {

vm/src/vm.rs

@@ -437,11 +437,7 @@ impl VirtualMachine {
     }
 
     fn _ne(&mut self, a: PyObjectRef, b: PyObjectRef) -> PyResult {
-        let b2 = &*b.borrow();
-        let a2 = &*a.borrow();
-        let result_bool = a2 != b2;
-        let result = self.ctx.new_bool(result_bool);
-        Ok(result)
+        self.call_method(a, "__ne__", vec![b])
     }
 
     fn _lt(&mut self, a: PyObjectRef, b: PyObjectRef) -> PyResult {