Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis's tasks todo before release #27

Closed
travistai2 opened this issue Jul 14, 2023 · 2 comments
Closed

Travis's tasks todo before release #27

travistai2 opened this issue Jul 14, 2023 · 2 comments
Assignees
Labels
for Version 1.0.0.0 Needs completing before official release

Comments

@travistai2
Copy link
Contributor

travistai2 commented Jul 14, 2023

List of To Do items for Travis to get done before release

    • Process ROMS data and upload to pacea-data
    • Help files and functions for remaining ROMS data
    • Ensure naming and numbering of ROMS data is appropriate for updating and searching in get_pacea_data function
    • Vignette - Plotting for ROMS data; plot.pacea_st, ggplot2, plotting time series of data
    • Vignette - Manipulating ROMS spatial data to format of interest
    • Decide on including updating data in function for users to update. (e.g. prompt user to check for data updates and if available, whether they want to update)
    • Decide on whether pacea_data object will include data that can be downloaded and data that is loaded with package
    • Possible to remove the dashed line that runs through BC for the EEZ? I (Andy) see it when doing plot(pdata, months = c("September"), years = c(2019), bc = T, eez = T) in your ROMS vignette.
    • News file for the package.
    • Process OISST data from erddap. 7 day average and monthly average. (Note: perhaps use package sftime to store spatiotemporal data in a neater format. Would also have to adjust ROMS data.
    • Documentation for OISST data
    • Use test_surftemp.rds for smaller file usage for tests and maybe vignettes too
    • push anomaly and climatology function to package once tested
@andrew-edwards andrew-edwards changed the title Tasks todo before release Travis's tasks todo before release Aug 1, 2023
@andrew-edwards andrew-edwards added the for Version 1.0.0.0 Needs completing before official release label Oct 23, 2023
@andrew-edwards
Copy link
Member

andrew-edwards commented Nov 6, 2023

  • I think we could do with a bit more info in the help files for the bccm outputs. Unless there is a master one they could all be linked to. For example ?bccm_all_variables doesn't really give much (e.g. even the acronym definition of bccm). I know we will tell people to work through the vignettes first (and don't want to repeat too much information), but I think the help files should have more info. Or maybe I'm missing something.

@andrew-edwards
Copy link
Member

andrew-edwards commented Nov 7, 2023

  • Also, I can't find the function to just download all the bccm data (have been meaning to do that for a while). Suggest including it in some help files, and also putting it more up front in the vignette. Most people will want to just download everything in one go I expect, to save waiting later (plus the results aren't going to be constantly updated).
  • I think you were okay with the shortened text I did at the start of the bccm text, so I'll take out the original text (it's still there).
  • I still have some edits I might do to the vignette, like removing some repetition, and change pdata to either p_data (for consistency) or something more meaningful. Prob worth chatting to bounce ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for Version 1.0.0.0 Needs completing before official release
Projects
None yet
Development

No branches or pull requests

2 participants