Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better understandability when doing peer.connect(...) #652

Open
quentincaffeino opened this issue Apr 17, 2020 · 2 comments
Open

Better understandability when doing peer.connect(...) #652

quentincaffeino opened this issue Apr 17, 2020 · 2 comments
Labels
bug client related to peerjs client confirmed acknowledged as an issue

Comments

@quentincaffeino
Copy link

While trying out this repo I stumbled upon the fact that peer.connect must be called only after peer open had successfully fired. Otherwise it won't work.
Is it intentional?
I haven't found anything about this behavior in docs, correct me if I'm wrong.
Maybe throwing an exception if connect called before peer has been opened might be a good tweak.

@afrokick afrokick added bug confirmed acknowledged as an issue labels Apr 20, 2020
@ppseprus
Copy link

ppseprus commented Apr 9, 2021

I wish I had seen this a couple hours ago... Thanks! This is THE BEST CONTENT! ; )

@AfeezGL
Copy link

AfeezGL commented Nov 13, 2021

I wish I had seen this before I started, had to think of it myself. peerjs needs to update their documentation.

@irgalamarr irgalamarr added the client related to peerjs client label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client related to peerjs client confirmed acknowledged as an issue
Projects
None yet
Development

No branches or pull requests

5 participants