Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode support in Windows #136

Open
pento opened this issue Mar 31, 2019 · 0 comments
Open

Dark Mode support in Windows #136

pento opened this issue Mar 31, 2019 · 0 comments
Labels

Comments

@pento
Copy link
Owner

pento commented Mar 31, 2019

Electron doesn't support Dark Mode in Windows, but we can manually check the registry for the setting.

Following Firefox's implementation, the setting is stored in the SOFTWARE\Microsoft\Windows\CurrentVersion\Themes\Personalize\AppsUseLightTheme key. It's only available on Windows 10.

There are various NPM modules for reading Windows registry values, unfortunately, none of them appear to implement watching, so we won't know when the value changes.

I suspect the best option might be to see if VSCode folks are interested in that feature being added to their module. If not, we can fork it and add it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant