Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package PerchRTC as a standalone library #7

Open
ceaglest opened this issue Jun 11, 2015 · 7 comments
Open

Package PerchRTC as a standalone library #7

ceaglest opened this issue Jun 11, 2015 · 7 comments
Assignees

Comments

@ceaglest
Copy link
Contributor

At the moment, the sample app directly integrates the PerchRTC classes. The core classes (everything except the view controller, connection broker, and other UI) should be separated into a standalone library installable via Cocoapods.

Class prefix must be changed from PH to something else, due to the photos framework conflict.

@whydna
Copy link

whydna commented Jan 3, 2016

@ceaglest any estimate on when this might be available?

@ceaglest
Copy link
Contributor Author

ceaglest commented Jan 5, 2016

@whydna I haven't had a lot of time to work on this project lately. However, I can take a look this weekend and submit a PR if everything goes well.

@ceaglest
Copy link
Contributor Author

@whydna @samsymons I got a pretty good start on this over the weekend. Most of the restructuring has been done, and the new Podfile is in place. However, I am running into a header search path issue with the pod. It appears that Cocoapods (v39.0) wants to flatten private and public headers even though the paths are preserved in the Pods dir. We workaround this in the sample app by setting a recursive header search path at the root, but this kludge doesn't hold for the Pod build process.

CocoaPods/CocoaPods#4057

https://github.com/perchco/perchrtc/tree/feature/sdk-repack

I'll have to give this a little more thought.

@hudoni
Copy link

hudoni commented Feb 1, 2016

@ceaglest Hi Christopher. I resolved the path issues and the compile phase was done. However, I've encountered another problem that it fails to link PerchRTC.framework with the static library "WebRTC-45-1-arm-intel-Release". Here are the messages:

Undefined symbols for architecture arm64:
"typeinfo for rtc::MessageHandler", referenced from:
typeinfo for rtc::FunctorMessageHandler<void, rtc::MethodFunctor1<perch::VideoCapturerKit, void (perch::VideoCapturerKit::)(cricket::CapturedFrame const), void, cricket::CapturedFrame const*> > in PHVideoCaptureBridge.o
"typeinfo for sigslot::multi_threaded_local", referenced from:
typeinfo for sigslot::_signal_basesigslot::multi_threaded_local in PHVideoCaptureBridge.o
"typeinfo for cricket::VideoCapturer", referenced from:
typeinfo for perch::VideoCapturerKit in PHVideoCaptureBridge.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

  • Target architecture: standard architectures - arm64 armv7
  • Xcode: Version 7.1 (7B91b)
  • Base SDK: iOS 9.1

Do you have any idea about this linking issue?

Thanks.

@FilHazer
Copy link

@hudoni +1

@ceaglest
Copy link
Contributor Author

ceaglest commented Mar 1, 2016

Hi @hudoni Thanks for the info. I got to the same point locally and ran into the linker problems. It's just a matter of a little tweaking with the Cocoapods setup at this point.

Unfortunately, I've been pretty busy with my FT job which has kept me off this project. The best I can do is set aside some time this weekend to resolve the problems and close out this feature. Once this blocker is out of the way it will be much easier to branch out into multiple demos, unit tests, better distribution etc... But lets take it one step at a time.

@carsonwu
Copy link

@hudoni I run into the same issue, did you ever find a solution for this? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants