We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P4V version: 2022.1.226.6529 P4VS version: 2021.2.226.2490 Visual Studio version: VS2019 16.11.15
On my computer, the "View in P4V" feature don't work, reporting an invalid string format.
It seems the problem comes from this line that cast the P4V.exe version number to double :
P4VS/P4VS/P4ScmProvider/P4ScmProvider.cs
Line 5619 in 0e1e7bd
Just using the en-US locale should be enough to fix the issue: double versionnum = Convert.ToDouble(line, new CultureInfo("en-US"));
double versionnum = Convert.ToDouble(line, new CultureInfo("en-US"));
The text was updated successfully, but these errors were encountered:
No branches or pull requests
P4V version: 2022.1.226.6529
P4VS version: 2021.2.226.2490
Visual Studio version: VS2019 16.11.15
On my computer, the "View in P4V" feature don't work, reporting an invalid string format.
![image](https://user-images.githubusercontent.com/43961858/170060525-51f718f0-b0b0-448a-86e6-d6eebf2fc7fd.png)
It seems the problem comes from this line that cast the P4V.exe version number to double :
P4VS/P4VS/P4ScmProvider/P4ScmProvider.cs
Line 5619 in 0e1e7bd
Many users have a system locale that don't use '.' as the floating point separator, and thus parsing of "2022.1" fail.
Just using the en-US locale should be enough to fix the issue:
double versionnum = Convert.ToDouble(line, new CultureInfo("en-US"));
The text was updated successfully, but these errors were encountered: