Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for file extension (throw a user-friendly exception) #181

Open
petrsvihlik opened this issue Feb 27, 2025 · 1 comment
Open

Add a check for file extension (throw a user-friendly exception) #181

petrsvihlik opened this issue Feb 27, 2025 · 1 comment
Assignees
@dviry
Labels
bug

Comments

@petrsvihlik
Copy link
Owner

Hi Petr,

I managed to find the root cause of the issue - CheckFileInfo.BaseFileName property is required to have extension (and I was only setting our blob name here).

For DOCX endpoint, this is not important, but for PPTX/XLSX it is... In all fairness, MS does say that extension is required here, however they do not make it easy to identify the problem.

Originally posted by @sf360bnedeljkovic in #169 (reply in thread)
@dviry dviry added the bug label Feb 28, 2025
@dviry dviry self-assigned this Feb 28, 2025
@dviry
Copy link
Collaborator

dviry commented Feb 28, 2025

will be fixed within #183

dviry pushed a commit to dviry/WopiHost that referenced this issue Mar 1, 2025
petrsvihlik#183 fix GetCheckFileInfo, petrsvihlik#162 allow customiza…
939ea13 
…tion of returned CheckFileInfo, petrsvihlik#181 fix BaseFileName extension, refactor IWopiSecurityHandler to async methods, add unit tests
@dviry dviry mentioned this issue Mar 1, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dviry dviry

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dviry @petrsvihlik