Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test SPQR Router config reload #1050

Open
40 tasks
Denchick opened this issue Feb 24, 2025 · 0 comments
Open
40 tasks

Test SPQR Router config reload #1050

Denchick opened this issue Feb 24, 2025 · 0 comments
Labels
documentation Improvements or additions to documentation go Pull requests that update Go code good first issue Good for newcomers

Comments

@Denchick
Copy link
Collaborator

Denchick commented Feb 24, 2025

This issue is only about the SPQR Router component.

SPQR Router supports configuration reloading (it reloads config on SIGHUP signal), although there is not enough testing for this feature at the moment.

We need to test (write more feature tests) as many settings as possible in the SPQR router config and document which ones actually support reloading and which are not.

  • log_level
  • time_quantiles
  • maintain_params
  • with_jaeger
  • pgproto_debug
  • log_filename
  • availability_zone
  • prefer_same_availability_zone
  • show_notice_messages
  • init_sql
  • use_init_sql
  • exit_on_init_sql
  • default_target_session_attrs
  • memqdb_backup_path
  • jaeger_url
  • frontend_rules
  • query_routing
  • frontend_tls
  • backend_rules
  • shards
  • schema_cache_backend_rule
  • multidb_pool_size
  • workload_file
  • workload_batch_size
  • ignore_cancel
  • acceptor_buffer_size
  • client_init_max
  • use_systemd_notifier
  • systemd_notifier_debug

What we defenetely don't want to support:

  • daemonize
  • host
  • router_port
  • router_ro_port
  • admin_console_port
  • grpc_api_port
  • world_shard_fallback
  • use_coordinator_init
  • router_mode
  • reuse_port
  • with_coordinator
@Denchick Denchick added documentation Improvements or additions to documentation good first issue Good for newcomers go Pull requests that update Go code labels Feb 24, 2025
@Denchick Denchick changed the title SPQR Router config reload Test SPQR Router config reload Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant