-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do we need vocabulary_counts in skipgram.py? #111
Comments
phucdoitoan
changed the title
Why do we need vocabulary_counts in Skipgram?
Why do we need vocabulary_counts in skipgram.py?
Feb 29, 2020
Yeah you are right! The skipgram.py implementation is based on a rather old version of Gensim word2vec; it is not necessary anymore. Would you like to clean this up? Happy to help with reviewing this. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I try to figure out the role of vocabulary_counts in skipgram.py, but it seems that the variable self.vocabulary_counts does not have any effect on the codes.
In the Word2Vec implementation https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/word2vec.py there is no use for vocabulary_counts neither.
Is it just a variable of an older version that is not necessary now?
The text was updated successfully, but these errors were encountered: