Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: Add comments to raw-data/create_adams_data.R? #98

Open
jimrothstein opened this issue Feb 22, 2025 · 0 comments
Open

General Issue: Add comments to raw-data/create_adams_data.R? #98

jimrothstein opened this issue Feb 22, 2025 · 0 comments
Assignees

Comments

@jimrothstein
Copy link
Collaborator

jimrothstein commented Feb 22, 2025

Background Information

This is good code, but might benefit from a small number of comments.

This script locates and runs ADaM templates in the various admirals packages.
A few comments would aid in future maintenance.

Examples:

  • system.file(package = 'pkg') returns? [depends on whether load_all() has run]
  • generally clarify which files and paths [often it is where the package is installed]

Definition of Done

no more than a few comments

@jimrothstein jimrothstein self-assigned this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant