Fix TreeBuilder in Symfony 4.2

A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.

Author: angelsk

pkg/async-event-dispatcher/DependencyInjection/Configuration.php

@@ -12,8 +12,8 @@ class Configuration implements ConfigurationInterface
      */
     public function getConfigTreeBuilder()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('enqueue_async_event_dispatcher');
+        $tb = new TreeBuilder('enqueue_async_event_dispatcher');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->children()
             ->scalarNode('context_service')->isRequired()->cannotBeEmpty()->end()

pkg/enqueue-bundle/DependencyInjection/Configuration.php

@@ -24,8 +24,8 @@ public function __construct(bool $debug)
 
     public function getConfigTreeBuilder(): TreeBuilder
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('enqueue');
+        $tb = new TreeBuilder('enqueue');
+        $rootNode = $tb->getRootNode();
 
         $rootNode
             ->requiresAtLeastOneElement()

pkg/enqueue/Tests/Symfony/DependencyInjection/TransportFactoryTest.php

@@ -37,8 +37,8 @@ public function testThrowIfEmptyNameGivenOnConstruction()
 
     public function testShouldAllowAddConfigurationAsStringDsn()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -59,8 +59,8 @@ public function testShouldAllowAddConfigurationAsStringDsn()
      */
     public function testShouldAllowAddConfigurationAsDsnWithoutSlashes()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -76,8 +76,8 @@ public function testShouldAllowAddConfigurationAsDsnWithoutSlashes()
 
     public function testShouldSetNullTransportIfNullGiven()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -93,8 +93,8 @@ public function testShouldSetNullTransportIfNullGiven()
 
     public function testShouldSetNullTransportIfEmptyStringGiven()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -110,8 +110,8 @@ public function testShouldSetNullTransportIfEmptyStringGiven()
 
     public function testShouldSetNullTransportIfEmptyArrayGiven()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -127,8 +127,8 @@ public function testShouldSetNullTransportIfEmptyArrayGiven()
 
     public function testThrowIfEmptyDsnGiven()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -140,8 +140,8 @@ public function testThrowIfEmptyDsnGiven()
 
     public function testThrowIfFactoryClassAndFactoryServiceSetAtTheSameTime()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -159,8 +159,8 @@ public function testThrowIfFactoryClassAndFactoryServiceSetAtTheSameTime()
 
     public function testThrowIfConnectionFactoryClassUsedWithFactoryClassAtTheSameTime()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
 
@@ -178,8 +178,8 @@ public function testThrowIfConnectionFactoryClassUsedWithFactoryClassAtTheSameTi
 
     public function testThrowIfConnectionFactoryClassUsedWithFactoryServiceAtTheSameTime()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
         $processor = new Processor();
@@ -196,8 +196,8 @@ public function testThrowIfConnectionFactoryClassUsedWithFactoryServiceAtTheSame
 
     public function testShouldAllowSetFactoryClass()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
         $processor = new Processor();
@@ -214,8 +214,8 @@ public function testShouldAllowSetFactoryClass()
 
     public function testShouldAllowSetFactoryService()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
         $processor = new Processor();
@@ -232,8 +232,8 @@ public function testShouldAllowSetFactoryService()
 
     public function testShouldAllowSetConnectionFactoryClass()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
         $processor = new Processor();
@@ -250,8 +250,8 @@ public function testShouldAllowSetConnectionFactoryClass()
 
     public function testThrowIfExtraOptionGiven()
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('foo');
+        $tb = new TreeBuilder('foo');
+        $rootNode = $tb->getRootNode();
 
         $rootNode->append(TransportFactory::getConfiguration());
         $processor = new Processor();

pkg/simple-client/SimpleClient.php

@@ -306,8 +306,8 @@ public function build(array $configs): void
 
     private function createConfiguration(): NodeInterface
     {
-        $tb = new TreeBuilder();
-        $rootNode = $tb->root('enqueue');
+        $tb = new TreeBuilder('enqueue');
+        $rootNode = $tb->getRootNode();
 
         $rootNode
             ->beforeNormalization()