Skip to content

Commit 1b4b01e

Browse files
author
Andy Hanson
committed
Unescape identifiers used in code completion
1 parent 29b1e79 commit 1b4b01e

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

src/harness/fourslash.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -717,6 +717,8 @@ namespace FourSlash {
717717
public verifyCompletionEntryDetails(entryName: string, expectedText: string, expectedDocumentation?: string, kind?: string) {
718718
const details = this.getCompletionEntryDetails(entryName);
719719

720+
assert(details, "no completion entry available");
721+
720722
assert.equal(ts.displayPartsToString(details.displayParts), expectedText, this.assertionMessageAtLastKnownMarker("completion entry details text"));
721723

722724
if (expectedDocumentation !== undefined) {

src/services/services.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3234,7 +3234,7 @@ namespace ts {
32343234
}
32353235
}
32363236

3237-
return name;
3237+
return unescapeIdentifier(name);
32383238
}
32393239

32403240
function getCompletionData(fileName: string, position: number) {
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
/// <reference path="fourslash.ts" />
2+
3+
// @Filename: a.js
4+
// @allowJs: true
5+
////__foo;/**/
6+
7+
goTo.marker();
8+
verify.completionListContains("__foo", undefined, undefined, "warning");

0 commit comments

Comments
 (0)