Skip to content

Commit 792b23e

Browse files
committed
Make isDefinition required.
For the deprecated getOccurrencesAtPosition, isDefinition is always false.
1 parent ac9e617 commit 792b23e

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/server/client.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,7 @@ namespace ts.server {
537537
fileName,
538538
textSpan: ts.createTextSpanFromBounds(start, end),
539539
isWriteAccess: entry.isWriteAccess,
540+
isDefinition: false
540541
};
541542
});
542543
}

src/server/protocol.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ declare namespace ts.server.protocol {
308308
/**
309309
* True if reference is a definition, false otherwise.
310310
*/
311-
isDefinition?: boolean;
311+
isDefinition: boolean;
312312
}
313313

314314
/**

src/services/services.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,7 +1208,7 @@ namespace ts {
12081208
textSpan: TextSpan;
12091209
fileName: string;
12101210
isWriteAccess: boolean;
1211-
isDefinition?: boolean;
1211+
isDefinition: boolean;
12121212
}
12131213

12141214
export interface DocumentHighlights {
@@ -5750,7 +5750,8 @@ namespace ts {
57505750
result.push({
57515751
fileName: entry.fileName,
57525752
textSpan: highlightSpan.textSpan,
5753-
isWriteAccess: highlightSpan.kind === HighlightSpanKind.writtenReference
5753+
isWriteAccess: highlightSpan.kind === HighlightSpanKind.writtenReference,
5754+
isDefinition: false
57545755
});
57555756
}
57565757
}

0 commit comments

Comments
 (0)