Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove partitioning DDL lost #1165

Closed
wk989898 opened this issue Mar 25, 2025 · 0 comments · Fixed by #1178
Closed

remove partitioning DDL lost #1165

wk989898 opened this issue Mar 25, 2025 · 0 comments · Fixed by #1178
Assignees
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@wk989898
Copy link
Collaborator

wk989898 commented Mar 25, 2025

What did you do?

create a changefeed with canal json protocol
run sql

use test;
CREATE TABLE t1 (
  PK INT PRIMARY KEY,
  COL INT
);

CREATE DATABASE foo;
USE foo;

CREATE TABLE bar (
  PK INT PRIMARY KEY AUTO_INCREMENT,
  COL INT
);
INSERT INTO bar VALUES (1, 1);

/* VIEW */
CREATE VIEW V1 AS 
SELECT *
FROM bar
WHERE COL > 2;
DROP VIEW IF EXISTS V1;

/* ALTER COLUMN */
ALTER TABLE bar
ADD COLUMN COL2 INT;
ALTER TABLE bar
MODIFY COLUMN COL2 FLOAT;
ALTER TABLE bar
DROP COLUMN COL2;

/* Rebase AutoID */
ALTER TABLE bar AUTO_INCREMENT=310;

/* Set DEFAULT value */
ALTER TABLE bar
ALTER COL SET DEFAULT 3;

/* Modify TABLE comment */
ALTER TABLE bar COMMENT = 'New table comment';

/* Modify TABLE charset */
ALTER TABLE bar CHARACTER SET = utf8mb4 COLLATE utf8mb4_unicode_ci;

/* Modify DATABASE charset */
ALTER DATABASE foo CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci;

CREATE TABLE t1 (
  PK INT PRIMARY KEY,
  COL INT
);

/* MultiSchemaChange */
ALTER TABLE test.t1 
CHANGE COL COL2 VARCHAR(255);
ALTER TABLE foo.t1 
CHANGE COL COL2 VARCHAR(255);

/* PARTITION */
CREATE TABLE t2 (
    id INT NOT NULL,
    year_col INT NOT NULL
)
PARTITION BY RANGE (year_col) (
    PARTITION p0 VALUES LESS THAN (1991),
    PARTITION p1 VALUES LESS THAN (1995),
    PARTITION p2 VALUES LESS THAN (1999)
);
ALTER TABLE t2 ADD PARTITION (PARTITION p3 VALUES LESS THAN (2002));
ALTER TABLE t2 REORGANIZE PARTITION p3 INTO (
    PARTITION p31 VALUES LESS THAN (2002),
    PARTITION p32 VALUES LESS THAN (2005),
    PARTITION p33 VALUES LESS THAN (2008)
);
ALTER TABLE t2 REORGANIZE PARTITION p31,p32,p33,p2 INTO (PARTITION p21 VALUES LESS THAN (2008));
ALTER TABLE t2 TRUNCATE PARTITION p0;
ALTER TABLE t2 DROP PARTITION p0;

/* ALTER INDEX visibility */
CREATE TABLE t3 (
  i INT,
  j INT,
  k INT,
  INDEX i_idx (i) INVISIBLE
) ENGINE = InnoDB;
CREATE INDEX j_idx ON t3 (j) INVISIBLE;
ALTER TABLE t3 ADD INDEX k_idx (k) INVISIBLE;
ALTER TABLE t3 ALTER INDEX i_idx VISIBLE;
ALTER TABLE t3 ALTER INDEX i_idx INVISIBLE;

/* RENAME TABLE */
RENAME TABLE t3 TO renam_t3;

/* INDEX */
CREATE TABLE t4 (col1 INT PRIMARY KEY, col2 INT);
CREATE INDEX idx1 ON t4 ((col1 + col2));
CREATE INDEX idx2 ON t4 ((col1 + col2), (col1 - col2), col1);
DROP INDEX idx1 ON t4;
ALTER TABLE t4 ADD INDEX ((col1 * 40) DESC);
ALTER TABLE t4 RENAME INDEX idx2 TO new_idx2;

/*
  Adding a new column and setting it to the PRIMARY KEY is not supported.
  https://docs.pingcap.com/tidb/stable/sql-statement-add-column#mysql-compatibility
  ALTER TABLE t4 ADD COLUMN `id` INT(10) primary KEY;
*/
/* 
  Dropping primary key columns or columns covered by the composite index is not supported.
  https://docs.pingcap.com/tidb/stable/sql-statement-drop-column#mysql-compatibility
  ALTER TABLE t4 DROP PRIMARY KEY;
*/

/* EXCHANGE PARTITION */
CREATE TABLE t5 (
    id INT NOT NULL PRIMARY KEY,
    fname VARCHAR(30),
    lname VARCHAR(30)
)
    PARTITION BY RANGE (id) (
        PARTITION p0 VALUES LESS THAN (50),
        PARTITION p1 VALUES LESS THAN (100),
        PARTITION p2 VALUES LESS THAN (150),
        PARTITION p3 VALUES LESS THAN (MAXVALUE)
);
INSERT INTO t5 VALUES (1669, "Jim", "Smith");
CREATE TABLE t6 LIKE t5;
ALTER TABLE t6 REMOVE PARTITIONING;
ALTER TABLE foo.t5 EXCHANGE PARTITION p0 WITH TABLE foo.t6;

/* 
  Debezium does not support recover table.
  DROP TABLE t1;
  RECOVER TABLE t1;
*/

DROP TABLE foo.bar;
DROP DATABASE IF EXISTS foo;

create table test.finish_mark
(
    id int PRIMARY KEY
);

What did you expect to see?

No response

What did you see instead?

CDC does not replicate ALTER TABLE t6 REMOVE PARTITIONING;

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants