Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection set incorrectly when closing active tabs opened from pinned tabs when appending to the end of the tree #1556

Closed
awused opened this issue Nov 17, 2017 · 1 comment

Comments

@awused
Copy link

awused commented Nov 17, 2017

Short description

The behaviour when closing closing tabs opened from pinned tabs is incorrect when using the

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Set tabs opened from pinned tabs to "Append to the end of the tree".
  4. Open a tab and pin it.
  5. Open another tab with the new tab button.
  6. Open a new tab from inside the pinned tab and select it.

Structure is now:
A (pinned)
B
C (selected, opened from A)

  1. Close tab C

Expected result

Tab B should be selected.

Actual result

Tab A is selected.

Opening a new tab while C is selected, either with the new tab button or from inside C, will fix the behaviour even if that fourth tab is immediately closed.

Environment

  • Platform (OS): Windows 10 x64
  • Version of Firefox: 57.0 (64-bit)
  • Version (or revision) of Tree Style Tab: 2.2.9
@awused
Copy link
Author

awused commented Nov 17, 2017

Never mind, this is caused by browser.tabs.selectOwnerOnClose. I'd love to see an option to disable this from inside TST or at least a warning about it causing confusing behaviour.

@awused awused closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant