Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sidebar width if bookmarks sidebar closed whilst tab is loading #3

Closed
edmorley opened this issue Dec 3, 2010 · 3 comments

Comments

@edmorley
Copy link
Contributor

edmorley commented Dec 3, 2010

Using:

  • Tree Style Tab 0.11.2010120301
  • Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101202 Firefox/4.0b8pre

STR:

  1. Set tab sidebar position to "left side"
  2. Open bookmarks sidebar using ctrl+B
  3. Middle mouse button click a bookmark to open in new tab
  4. Immediately close the bookmarks sidebar using ctrl+B (whilst tab still shows "connecting...").

Expected:

  • When bookmark sidebar is hidden, tree style tab sidebar should have it's on-screen position updated correctly.

Actual:

  • If step number 4 is performed whilst the tab still shows "connecting..." (ie: very soon after middle clicking), then the tree style tab sidebar displays incorrectly, similar to the graphical issues caused by this other (now fixed bug): https://github.com/piroor/treestyletab/issues#issue/2
@piroor
Copy link
Owner

piroor commented Dec 6, 2010

I think this patch should fix the bug.
9c8eaf6

@piroor
Copy link
Owner

piroor commented Dec 6, 2010

Sorry, I wrongly closed this topic...

@edmorley
Copy link
Contributor Author

Fixed, thanks.

Nephyrin added a commit to Nephyrin/treestyletab that referenced this issue Aug 27, 2014
piroor pushed a commit that referenced this issue Nov 23, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
hope -> want
piroor pushed a commit that referenced this issue Jan 28, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Pull
piroor pushed a commit that referenced this issue Nov 3, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge upstream.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants