-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HUD is not working inside extensions #122
Comments
Please can you print the log and your code? Thanks |
@ramunasjurgilas You cannot use PKHUD in an extension. The reason is that PKHUD tries to access UIApplication.shared which is forbidden in app extensions. There is a fork by @Fab1n you can use: https://github.com/teamoutbank/PKHUD @pkluz Any chance that the view-based implementation by @Fab1n gets merged into the original PKHUD? https://github.com/teamoutbank/PKHUD/pull/1 |
@PGLongo Error happens because it uses UIApplication, but in share extensions it is not accessible/forbidden as @domhof wrote. Error it self happens the 5th line.
@domhof Thanks for comment. |
@ramunasjurgilas If you want you can use my fork of PKHUD https://github.com/domhof/PKHUD. It is based on @pkluz s fork, but updated to 4.0.0 for Swift 3 support. |
@domhof I've seen your fork. Any idea on how fix this problem without breaking the compatibility? |
Hey guys. Our fork is view based AND compatible with macOS. If you take the branch feature/ob-additions you will get all goodness AND Swift 3 support! As the name oft the branch tells you, we made all changes additional on top of the official pkhud master. So it should be very simple to merge |
And we hope to get this into the official master. Would be an improvement |
+1 on getting them merged nicely.
… On 6 Dec 2016, at 1:51 PM, Fabian Renner ***@***.***> wrote:
And we hope to get this into the official master. Would be an improvement
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@Fab1n it would be great if you could make a PR. |
Here it is Hope this gets pulled in soon |
I can make some test this Friday. |
I've merge only 1 commit of that PR. Today I will check and merge others PR and then release a new pod version. |
Released the new version. Try update your pod to 4.1.0 and then let me know. Thanks |
Sorry no, currently it is not possible to use that from an extension. You should propose a pullRequest or open a ticket for that. Maybe there is one already |
I'm looking into it but it's very difficult for me at the moment to fix this. If you have the time you could try the following:
|
When using HUD inside extension (as I am using in Share extension) it crashes.
The text was updated successfully, but these errors were encountered: