Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password protected sites producing an error (and more problems) #9

Open
Zodiac1978 opened this issue Oct 3, 2018 · 2 comments
Open
Milestone

Comments

@Zodiac1978
Copy link
Member

Zodiac1978 commented Oct 3, 2018

I think 401 should be ignored too, like 405:
https://github.com/pluginkollektiv/spcl/blob/develop/inc/class-spcl.php#L230

People could want to link on password protected sites which need authorization.
See also: https://core.trac.wordpress.org/ticket/36638#comment:5

Maybe just rejecting 404 and 410 as suggested here:
https://core.trac.wordpress.org/ticket/36638#comment:7

On the other hand the whole check is not very reliable at all:
https://core.trac.wordpress.org/ticket/36638#comment:28

Linkedin pages are returning 999 as status code for example.
Medium seems to reject Requests from WordPress with a 403.
https://core.trac.wordpress.org/ticket/36638#comment:32

And more reasons to skip the whole thing altogether:
https://core.trac.wordpress.org/ticket/36638#comment:46

@patrickrobrecht
Copy link
Member

I think that the current check should be ok as dealing with all the mentioned cases may hide real errors as well. Maybe we could add a hint that there might be false positives.

@patrickrobrecht
Copy link
Member

patrickrobrecht commented May 22, 2020

Another idea would be to add specific URLs (those which require login, specific user rights or are password protected) to an ignore list (you would get the error once and could click on "Ignore" and afterwards the error is hidden). Linkedin and Medium could be in the ignore list by default due to their rejection of WordPress requests.

This way we avoid to hide actual errors.

@patrickrobrecht patrickrobrecht added this to the 1.1.0 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants