Retry during heavy load results in Retry Hell

[TheCrabity]

When a Worker is hitting the Rate Limit, we don't respect maxTries and the worker can enter a Retry Hell, with 30 or more seconds before the promise is returned. Have an option to throw an error (and handle retries ourself), or retry only as many times as maxTries would prevent this.

https://github.com/pogosandbox/pogobuf/blob/master/pogobuf/pogobuf.client.js#L610

Temp work around that corrects this issues:

            if (responseEnvelope.status_code === 52 && self.endpoint !== INITIAL_ENDPOINT) {
                  throw new retry.StopError(
                    `Status code ${responseEnvelope.status_code} received from RPC`
                );
            }

[niicojs]

Could you try https://github.com/pogosandbox/pogobuf/tree/throttlinghell ?
Just a attempt, I didn't test much

[TheCrabity]

Setting maxTriesThrottling: to 0 or 1, still results in the odd double retry attempt, as seen above.

[niicojs]

I don't really get how that's possible.
Could you debug this part or add log to see what's going on?

if (responseEnvelope.status_code === 52 && self.endpoint !== INITIAL_ENDPOINT) {
    self.throttled++;
    if (self.throttled < self.options.maxTriesThrottling) {
        return Promise.delay(2000).then(() => self.tryCallRPC(requests, signedEnvelope));
    } else {
        throw new retry.StopError(`Throttled ${self.throttled} times`);
    }
}