Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zed: Issue with setting logLevel #264

Open
DavisVaughan opened this issue Feb 25, 2025 · 0 comments
Open

Zed: Issue with setting logLevel #264

DavisVaughan opened this issue Feb 25, 2025 · 0 comments

Comments

@DavisVaughan
Copy link
Collaborator

If you set

    "air": {
      "initialization_options": {
        "logLevel": "trace"
      }
    }

Then it correctly sets the log level to "trace" using the initialization option of air.logLevel, but if you change anything in the configuration after that then we try and re-pull the non-initialization version of air.logLevel (as we refresh everything) but this time around air.logLevel is None, so we end up reverting the log level back to "info", throwing out that initialization option of "trace".

This isn't a problem in VS Code because air.logLevel corresponds to both what we pull as the initialization option AND what we pull dynamically. In Zed I think they are separate, although I can't figure out how to set the non-initialization option of air.logLevel (it might not be possible).

We could say "if we pull air.logLevel=None and we have a previously set logLevel, then don't update the log level", but I worry about what that would mean for vs code, because in VS Code you may start with

"air.logLevel": "trace"

but then you may remove that line and expect it to go back to "info", but it won't if we do this. Although that may be a small price to pay for it to work mostly as expected elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant