Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken and missing links in En, Jp, zh-Hans contributior_docs web_accessibility.md #7204

Open
1 of 17 tasks
22nds opened this issue Sep 3, 2024 · 4 comments
Open
1 of 17 tasks
Labels

Comments

@22nds
Copy link

22nds commented Sep 3, 2024

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

p5.js version

latest

Web browser and version

all

Operating system

all

Steps to reproduce this

Steps:

  1. Go to https://github.com/processing/p5.js/blob/main/contributor_docs/web_accessibility.md
  2. Missing/incorrect links are in the second and third paragraph
    "If you want to make your sketches screen reader-accessible, visit the How to label your p5.js code tutorial.

If you want to use p5.js with a screen reader, visit the Using p5.js with a Screen Reader tutorial."

Corrections for English version:

Affected docs are in the following languages: English, JP, zh-Hans

Please assign this issue to me and I'll submit PR.

@22nds 22nds added the Bug label Sep 3, 2024
Copy link

welcome bot commented Sep 3, 2024

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

@williamthazard
Copy link

Hi! Just wanted to check in on this since it's been a couple days. Is there anything else that needs to be done on filing this issue, per the bot? Or is there any other way I can help with this? This seems like a pretty easy fix; it'd be great to see it resolved and to see accessibility consequently improved

@Qianqianye
Copy link
Contributor

Thanks @22nds for opening this issue, and @williamthazard for your interests in working on this. There are multiple broken links issues across p5.js repo and p5.js website repo, so it's taking us a bit longer to coordinate. For the particular links mentioned in this issue, they are fixed in the English version.

If you are interested, please feel free to open a PR to fix the links in ja and zh-hans translated version. Thank you!

@Bhavyabhardwaj
Copy link

This issue is still opened. Please assign this issue to me and I'll submit PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants