Unicode index() now considers the last character. Fixes dop251#59.

dop251 · dop251 · commit 034fb74b51e6 · 2018-01-02T12:14:21.000Z
diff --git a/runtime_test.go b/runtime_test.go
@@ -185,12 +185,10 @@ func TestIndexOf(t *testing.T) {
 
 func TestUnicodeIndexOf(t *testing.T) {
 	const SCRIPT = `
-
-	"абвгд".indexOf("вг", 1)
-
+	"абвгд".indexOf("вг", 1) === 2 && '中国'.indexOf('国') === 1
 	`
 
-	testScript1(SCRIPT, intToValue(2), t)
+	testScript1(SCRIPT, valueTrue, t)
 }
 
 func TestLastIndexOf(t *testing.T) {
diff --git a/string_unicode.go b/string_unicode.go
@@ -236,7 +236,7 @@ func (s unicodeString) index(substr valueString, start int64) int64 {
 
 	// TODO: optimise
 	end := int64(len(s) - len(ss))
-	for start < end {
+	for start <= end {
 		for i := int64(0); i < int64(len(ss)); i++ {
 			if s[start+i] != ss[i] {
 				goto nomatch

Original file line number	Diff line number	Diff line change
`@@ -185,12 +185,10 @@ func TestIndexOf(t *testing.T) {`
`185`	`185`
`186`	`186`	`func TestUnicodeIndexOf(t *testing.T) {`
`187`	`187`	const SCRIPT = `
`188`		`-`
`189`		`- "абвгд".indexOf("вг", 1)`
`190`		`-`
	`188`	`+ "абвгд".indexOf("вг", 1) === 2 && '中国'.indexOf('国') === 1`
`191`	`189`	`
`192`	`190`
`193`		`- testScript1(SCRIPT, intToValue(2), t)`
	`191`	`+ testScript1(SCRIPT, valueTrue, t)`
`194`	`192`	`}`
`195`	`193`
`196`	`194`	`func TestLastIndexOf(t *testing.T) {`