Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termination marker for scrapes #11

Closed
brian-brazil opened this issue Jul 18, 2017 · 6 comments
Closed

Termination marker for scrapes #11

brian-brazil opened this issue Jul 18, 2017 · 6 comments

Comments

@brian-brazil
Copy link
Contributor

prometheus/docs#546

@brian-brazil
Copy link
Contributor Author

I'm for # END\n at the end of the format (maybe not the \n if there's an EOF, that's a common mistake).

@RichiH
Copy link
Member

RichiH commented Jul 18, 2017

# END\n makes sense. Short IETF speak suggestion: MUST be sent, MUST be accepted without it being sent, SHOULD be exposed to the user.if missing.

@brian-brazil
Copy link
Contributor Author

MUST be accepted without it being sent,

The whole point of this is to prevent incomplete scrapes, it MUST be rejected if it isn't sent.

@RichiH
Copy link
Member

RichiH commented Jul 18, 2017

Isn't partial information better than no information at all?

I don't feel strongly either way, as things not being up (or whatever other implementations call it) is a strong incentive to dig at what's wrong.

@brian-brazil
Copy link
Contributor Author

Isn't partial information better than no information at all?

It's worse than no information, as queries tend to be written presuming that a whole scrape comes at once.

Correctly dealing with a model where an arbitrary subset of the data can be returned at each scrape would be close to impossible, even for an expert.

@RichiH
Copy link
Member

RichiH commented Oct 10, 2017

Specific to text format (and maybe some others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants