Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only double values #132

Closed
bogdandrutu opened this issue Apr 15, 2019 · 1 comment
Closed

Support only double values #132

bogdandrutu opened this issue Apr 15, 2019 · 1 comment

Comments

@bogdandrutu
Copy link

The proto data model defines as supported types for Gauge, Counters int and double.

Reasons to not support int:

  • The text model supports "All values are float64".
  • Converting proto -> text -> proto will may not generate the same proto (no information if the initial value was int or double).
  • Int values does not bring too much benefit (float64 has a good enough precision for large ints).
  • The metric type does not include information about the exported value type - based on the current proto definition backends need to support for one metric injection of both int/double because this information is not in the MetricDescriptor. This complicates the backend logic for products that want to offer support for both int and double.

I would suggest to simply remove the int support and only support double values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants