Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus: Label values are strings only; not int, not float, not bool #56

Closed
RichiH opened this issue Oct 11, 2017 · 4 comments
Closed

Comments

@RichiH
Copy link
Member

RichiH commented Oct 11, 2017

No description provided.

@curlup
Copy link

curlup commented Oct 27, 2017

How about histogram bounds in labels? (https://github.com/RichiH/OpenMetrics/issues/)
Say, the upper bound label is le="0.01" which is string representation of a float value, and I suppose a user might want to select them on le<1 or alike condition.

@brian-brazil
Copy link
Contributor

That's a matter for the text representation, and the ingesting backends to handle. I presume/hope we'll continue to use the le label as we currently do.

@jkschneider
Copy link

le implies that histograms are always cumulative. But this is the opinion of Prometheus. Do we intend to impose that? Atlas uses normal histograms.

@brian-brazil
Copy link
Contributor

brian-brazil commented Aug 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants