-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version information in text/protobuf or header only? #84
Comments
I can see that causing confusion, as for example implementors may set that and not the HTTP header and break parsers. I think it's best to keep this to a single place, and I think out of band is fine for that. |
The test suite would catch that. We could also not have this information in the header, but I don't feel as if I have thought that possibility through, yet. |
If you're using HTTP, the content type belongs in the header - and is needed if you're going to be doing sane content type negotiation. I'm not sure we should be changing the protocol just to workaround a security feature in one browser. |
https://developer.chrome.com/extensions/webRequest#event-onHeadersReceived it is possible to examine headers in Chrome's plugin system. What I've found is that just version in the header seems not enough. It would be great to have |
The content type will include "openmterics". |
@brian-brazil Great! Than for me this issue can be closed 👍 |
As part of the RFC process, we did apply for As such, this is all out-of-band. |
fhemberger/prometheus-formatter#1 (comment) raises an interesting point: Not all systems may have access to the header information.
Conceivably, there might not even be any HTTP involved at all in some uses cases
Having version information in the body would generally make sense and be lightweight enough in relation to a usual payload.
The text was updated successfully, but these errors were encountered: