Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eldoc for custom python-shell-interpreter #12

Closed
Pitometsu opened this issue Jan 21, 2018 · 3 comments
Closed

Fix eldoc for custom python-shell-interpreter #12

Pitometsu opened this issue Jan 21, 2018 · 3 comments

Comments

@Pitometsu
Copy link

With

'(python-shell-interpreter "ipython")

There's error:

eldoc error: (file-error Searching for program No such file or directory ipython)

In *Messages*.

@Pitometsu Pitometsu mentioned this issue Jan 21, 2018
@pwalsh pwalsh added this to the Current milestone Jan 21, 2018
@pwalsh
Copy link
Owner

pwalsh commented Jan 21, 2018

@Pitometsu

If python-shell-interpreter is "ipython", it seems unlikely that you are in a virtual environment being managed by Pipenv, as if it were, there would be a value like /Users/netsu/.local/share/virtualenvs/csr-44kfYsMA/bin/python.

Did you add "ipython" manually? Maybe, as I wrote here you want pipenv.el to use an ipython executable as the python-shell-interpreter from the active virtual environment, if such an executable exists?

@Pitometsu
Copy link
Author

It would be nice, if pipenv remember original (customized by user) python-shell-interpreter value, and would try to call it from environment. But proposed approach ok for me.

@pwalsh
Copy link
Owner

pwalsh commented Feb 8, 2018

pipenv.el no longer modifies python-shell-interpreter, so user settings are respected for this variable.

pipenv.el now pushes the virtual env path to (exec-path) when a pipenv-managed project is activated, for example by (pipenv-activate).

@pwalsh pwalsh closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants