New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`impl/src/lib.rs` readability improvement #254

Closed

hamirmahal opened this issue Jan 1, 2025 · 0 comments · Fixed by #255

Contributor

hamirmahal commented Jan 1, 2025

We can get a readability improvement by replacing

  let crate_path: syn::Path = find_attribute_values(ast, "crate_path")
    .last()
    .map(|v| syn::parse_str(v).unwrap())
    .unwrap_or_else(|| syn::parse_str("rust_embed").unwrap());

with

  let crate_path: syn::Path = find_attribute_values(ast, "crate_path")
    .last()
    .map_or_else(|| syn::parse_str("rust_embed").unwrap(), |v| syn::parse_str(v).unwrap());

hamirmahal mentioned this issue

refactor: replace map().unwrap_or_else() #255

Merged

pyrossh closed this as completed in #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment