Skip to content

Use Python versioning in msgfmt.py/pygettext.py #133319

Closed as not planned
Closed as not planned
@StanFromIreland

Description

@StanFromIreland

pygettexts/msgfmts versioning system is currently not useful.

__version__ = '1.5'

__version__ = "1.2"

It has not been updated with changes and is of little informational value.

We have three options,

  1. Leave it as it is
  2. Remove it
  3. Replace/Update it to make it useful

1 = nothing changes.

2 Removing it completely would be misleading since pot files without "Generated-By: XXX" in the header are assumed to be generated by xgettext, so we would have to keep "Generated-By: pygettext".

I propose to do 3, as the version number can be useful, since files generated by different versions of the scripts can vary. For reference python-babel does this with their up-to-date version no. To do this I propose to use CPython versioning to make it easier, both for us and for users. This will avoid discussions down the line as to when should we bump the version, and it will make it easier for users to fetch the desired version, i.e. branch 3.15 for pygettext 3.15 and so on.

cc @tomasr8

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    triagedThe issue has been accepted as valid by a triager.type-featureA feature request or enhancement

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions