-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Several tests fail when system encoding is latin-1
#133677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@StanFromIreland This is likely due to how cpython expects char and file encodings and ends up trying to decode/encode chars that don't exist in TD;LR: Latin 1 can't encode characters such as U+4e00 which was mentioned in some error messages because there is no encoding for that unicode char in latin1! Latin 1 is 256 characters vs. Unicode ... This log output only proves it:
This should probably be documented in the devguide. I'd be happy do it. |
I am well aware, and I have read the error messages. The problem is that tests should be skipped if they are not supported by the platform (or updated to do so). |
@StanFromIreland This is also a valid solution I'll start working on a PR. |
@StanFromIreland For test httpservers this might be okay, but for other ones like test_zipfile it might be extremely hard to pinpoint it. I'll work on a fix for that |
This will only affect < 3.15 when PEP 686 is implemented.
Bug report
Bug description:
See buildbot run. (Note: some tests are failing due to the timezone, that is tracked in a separate issue)
test_httpservers
test_zipfile
test_asyncio
test_argparse (presumably)
test_pathlib (presumably)
test_urllib (possibly due to character in filename)
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
test_httpservers
if not utf-8 #133706test_zipfile
if not UTF-8 #133715The text was updated successfully, but these errors were encountered: