Skip to content

Missing error handling in SET_COUNT macro in _testinternalcapi.c #133891

Closed
@sobolevn

Description

@sobolevn

Bug report

Refs #133265

Right here PyLong_FromLong can in theory (unlikely in practice) return NULL. It is missing this check. I understand that this is a test code, but I also don't see a reason why we should not be explicit about it.

#define SET_COUNT(DICT, STRUCT, NAME) \

cc @ericsnowcurrently

I have a PR ready.

Linked PRs

Metadata

Metadata

Assignees

Labels

3.14bugs and security fixes3.15new features, bugs and security fixesextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions