From 43cbd3954f749855dbad4f176073eb03baa7f994 Mon Sep 17 00:00:00 2001 From: neonene <53406459+neonene@users.noreply.github.com> Date: Tue, 27 May 2025 02:46:49 +0900 Subject: [PATCH] gh-134557: Suppress immortalization in _PyCode_GetScriptXIData under free-threading (gh-134686) Disable immortalization around Py_CompileString*(). The same approach as 332356b that fixed the refleaks in compile() and eval(). (cherry picked from commit c60f39ada625562bff26400f304690c19fe9f504) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com> E: 09e72cf can pass test_capi, test_sys and test__interpchannels with this patch for me. --- Python/crossinterp.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Python/crossinterp.c b/Python/crossinterp.c index 26eecdddf4bdd0..13d91c508c41fa 100644 --- a/Python/crossinterp.c +++ b/Python/crossinterp.c @@ -908,8 +908,15 @@ get_script_xidata(PyThreadState *tstate, PyObject *obj, int pure, } goto error; } +#ifdef Py_GIL_DISABLED + // Don't immortalize code constants to avoid memory leaks. + ((_PyThreadStateImpl *)tstate)->suppress_co_const_immortalization++; +#endif code = Py_CompileStringExFlags( script, filename, Py_file_input, &cf, optimize); +#ifdef Py_GIL_DISABLED + ((_PyThreadStateImpl *)tstate)->suppress_co_const_immortalization--; +#endif Py_XDECREF(ref); if (code == NULL) { goto error;