chore(nodejs): regexp for table and column name validations #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flame diagrams show that validating and writing strings are the hot places in the code, looping through the characters of strings is slow.
Replacing it with regular expressions in table and column name validation and character escaping improves performance significantly.
However, this is true only when the code using the client does not generate garbage.
When the client code is not gc-free overall performance is about the same with regexp.
In real life use cases unlikely that we will see gc-free clients so the 200k rows/s ingestion speed remains theoretical but I think it still makes sense to use regexp instead of the for loops.
It can lead to performance improvements when the client code does not generate much garbage.