Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift in mod and import styles is confusing #524

Open
leighstillard opened this issue Feb 19, 2022 · 1 comment
Open

Shift in mod and import styles is confusing #524

leighstillard opened this issue Feb 19, 2022 · 1 comment

Comments

@leighstillard
Copy link
Contributor

Hi there,

Around about the math section the style changes from using a single module across both the test and main file to using a mod for each. The shift isn't explained as far as I can tell, and the code examples reference files in this repo - which from my experience doesn't work well when transcribing or copying code to learn.

Is there a good practice reason for the switch? It would help to explain the transition.

I submitted a PR to 'fix' the maths section but on further consideration I'm not confident that was the right thing to do.

@quii
Copy link
Owner

quii commented Feb 19, 2022

It's just a function of it all growing organically, that particular chapter was also not written by me! I confess I haven't looked at that chapter in a long time, so I'll try and find some time at some point. The setup with go mod these days is relatively straightforward so hopefully not too much of a chore to fix. Thanks for raising

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants