Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Redis with TLS #1031

Closed
ghost opened this issue Sep 14, 2022 · 2 comments · Fixed by #1032
Closed

Use Redis with TLS #1031

ghost opened this issue Sep 14, 2022 · 2 comments · Fixed by #1032

Comments

@ghost
Copy link

ghost commented Sep 14, 2022

Feature Request

Is your feature request related to a problem? Please describe.

The redis SaaS offering I am using requires tls connections. Afaik there currently is no option to pass a ca certificate to be used in ioredis.

Describe the solution you'd like

The optimal solution for me would be if one could set an environment variable REDIS_TLS_CA_FILE, that is being picked up by ioredis.

Describe alternatives you've considered

Not using redis with tls, or setting NODE_TLS_REJECT_UNAUTHORIZED to ioredis doesn't complain about a self signed certificate.

Teachability, Documentation, Adoption, Migration Strategy

https://github.com/luin/ioredis#tls-options

@Skn0tt
Copy link
Member

Skn0tt commented Sep 14, 2022

Hi @boredland-ioki! Sounds like a good addition, would you like to contribute a PR for it? I think this is the code that would need to be extended:

redis = new IORedis(redisUrl);

I can also make a PR for it, just let me know :)

@boredland
Copy link
Contributor

Sure, will do!

boredland added a commit to boredland/quirrel that referenced this issue Sep 14, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
boredland added a commit to boredland/quirrel that referenced this issue Sep 14, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
boredland added a commit to boredland/quirrel that referenced this issue Oct 12, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants