-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Signature is missing" when using quirrel with sveltekit in production mode #1128
Comments
Thanks for the detailed report! Looks like SvelteKit changed the types of the @all-contributors please add @bamthomas for bug |
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @bamthomas! 🎉 |
Adds @bamthomas as a contributor for bug. This was requested by Skn0tt [in this comment](#1128 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Shipped in https://github.com/quirrel-dev/quirrel/releases/tag/v1.13.3, please let me know if that works for you. |
Thank you very much for the fix and the add. I'm going to test it soon, I will update this comment. |
Bug Report
Current Behavior
When using quirrel with sveltekit in production we have the error
Signature is missing
when quirrel calls the app.The code :
Is getting
undefined
in thesignature
variable.It seems that headers object is a Map and I'm not sure we can read the header with
headers["x-quirrel-signature"]
:Expected behavior/code
The header is correctly read.
Environment
ghcr‧io/quirrel-dev/quirrel:sha-fbfa761
Possible Solution
I'm not sure how to fix this (that's the reason I didn't make a PR) because :
is working but maybe it won't work for other environments.
maybe :
What do you think ?
As a workaround I'm doing a sed in the file while building my app.
The text was updated successfully, but these errors were encountered: